fix: discard networks with invalid information#24
Open
doertydoerk wants to merge 1 commit intotheojulienne:masterfrom
Open
fix: discard networks with invalid information#24doertydoerk wants to merge 1 commit intotheojulienne:masterfrom
doertydoerk wants to merge 1 commit intotheojulienne:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello mate!
I was wondering whether this repo is under maintenance? Since the latest master seems kind of broken, I checked out 1.2.0 and based my commit on that.
We ran into a problem where we got a list of access points in which the last one was broken. That lead to an error returned based on the fact that the list could not be parsed. My changes mitigate that. Basically, all good networks will be returned, and the broken ones are getting discarded.
As I had to branch from 1.2.0 I would like to rebase to latest and submit a proper pull request. So, please let me know when master is fixed.
Kind regards
Dirk