Updated readme + Ability to retain log_group after service deleted #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guslington
reviewed
Dec 17, 2021
|
|
||
| definitions, task_volumes, secrets = Array.new(3){[]} | ||
| secrets_policy = {} | ||
| secrets_policy = external_parameters.fetch(:secrets_policy, {}) |
Member
There was a problem hiding this comment.
@kyletbase2 What's the use case for a custom secrets policy?
Contributor
Author
There was a problem hiding this comment.
@Guslington This was for a customer who wanted to retrieve DB credentials from Secrets Manager, and pass it to an ECS task using "ValueFrom" environment variables. Maybe there's a better / supported way to do this, but I couldn't find it.
The AWS docs say this needs to be given to the task execution role (not task role, which afaik is what the iam_policies config modifies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.