Skip to content

allow task role name #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dupontz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow task role name #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ecs-task.cfndsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

log_retention = external_parameters.fetch(:log_retention, 7)
log_group_name = external_parameters.fetch(:log_group_name, Ref('AWS::StackName'))

task_role_name = external_parameters.fetch(:task_role_name, nil)

Logs_LogGroup('LogGroup') {
LogGroupName log_group_name
RetentionInDays log_retention
Expand Down Expand Up @@ -286,6 +289,7 @@
AssumeRolePolicyDocument service_assume_role_policy(['ecs-tasks','ssm'])
Path '/'
Policies(iam_role_policies(iam_policies))
RoleName task_role_name unless task_role_name.nil?
end

IAM_Role('ExecutionRole') do
Expand Down
Loading