chore: ODP Schema v0.7.7 mappings#933
Conversation
| source: "Planning Data", | ||
| "digital-land-datasets": ["certificate-of-immunity"], | ||
| category: "Heritage and conservation", | ||
| }, |
There was a problem hiding this comment.
| model: "Google Gemini", | ||
| }, | ||
| ], | ||
| }), |
There was a problem hiding this comment.
Based on example passport output of an EnhancedTextInput (note we need to update project.description to proposal.description for consistency in editor):
There was a problem hiding this comment.
Now correct in PlanX editor too ✅ theopensystemslab/planx-new#6218
| * Total calculated fee in GBP | ||
| */ | ||
| calculated: number; | ||
| calculatedVAT?: number; |
There was a problem hiding this comment.
Do we want a comment for this, like for payableVAT? of course, it's obvious what it is :)
There was a problem hiding this comment.
Good observation - these types are auto-generated from preApplication/schema.json and never manually edited so comments can be a little inconsistent depending on use of @id, @description etc in the JSON Schema itself !
As JSON side is already released, going to ignore this for now but have a note to double-check at the source in next round of edits!
There was a problem hiding this comment.
nice, that's great! was just a curiosity :)
| }, | ||
| fee: this.getBaseFee( | ||
| false, | ||
| ) as PreApplicationPayload["data"]["application"]["fee"], |
There was a problem hiding this comment.
TS can't work out what type should be returned depending on the bool submitted? sad!
There was a problem hiding this comment.
Maybe there's smarter syntax here but I couldn't figure it out! Honestly lots of maybe-unnecessary/overly-cautious as casting throughout this file to revisit one day !
2 participants
Relies on theopensystemslab/digital-planning-data-schemas#393
.jsonfiles & ranpnpm generate-types-from-schemamodel.tsmappings as necessary