bump node (to v24 LTS), pnpm and packages#934
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Node/pnpm toolchain and dependency set (aligned with the related planx-new work) and adjusts a performance-sensitive test to avoid measuring JSON parse time.
Changes:
- Bump Node to v24.14.0 (and update CI to use the same pinned version).
- Bump pnpm to 10.30.2 and update various runtime/dev dependencies + lockfile.
- Preload the large flow fixture once in session logic tests to keep perf timings focused on the algorithms.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/models/session/logic.test.ts |
Preloads the large flow fixture once and reuses it in perf-related assertions. |
package.json |
Updates dependency versions and pins packageManager to pnpm 10.30.2; updates @types/node for Node 24. |
pnpm-lock.yaml |
Regenerates lockfile to reflect Node/pnpm/package bumps. |
.nvmrc |
Pins local Node version to v24.14.0. |
.github/workflows/test.yml |
Pins CI Node/pnpm versions to match the updated toolchain. |
.husky/pre-commit |
Adds a note about Husky v10 deprecations. |
.github/dependabot.yml |
Removes reviewer auto-assignment and normalizes YAML formatting. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jessicamcinchak
approved these changes
Feb 27, 2026
| import * as simple from "./mocks/simple-flow-breadcrumbs.js"; | ||
|
|
||
| // pre-load large flow JSON to exclude parsing time from performance measurements | ||
| const largeFlow = getLargeFlow(); |
freemvmt
force-pushed
the
dg/bump-node-pnpm
branch
from
d0842d4 to
c2d14be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of pentest prep, and to coincide with the same work in
planx-new(#6227).