Skip to content

Fix partition checking #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix partition checking #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compat/install-9.6.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@
-RETURNS TEXT AS $$
- SELECT _are(
- 'partitions',
- ARRAY(SELECT _parts($1, $2) EXCEPT SELECT unnest($3)),
- ARRAY(SELECT unnest($3) EXCEPT SELECT _parts($1, $2)),
- ARRAY((SELECT _parts($1, $2)::text collate "C" EXCEPT SELECT unnest($3)) ORDER BY 1),
- ARRAY((SELECT unnest($3)::text collate "C" EXCEPT SELECT _parts($1, $2)) ORDER BY 1),
- $4
- );
-$$ LANGUAGE SQL;
Expand All @@ -120,8 +120,8 @@
-RETURNS TEXT AS $$
- SELECT _are(
- 'partitions',
- ARRAY(SELECT _parts($1) EXCEPT SELECT unnest($2)),
- ARRAY(SELECT unnest($2) EXCEPT SELECT _parts($1)),
- ARRAY((SELECT _parts($1)::text collate "C" EXCEPT SELECT unnest($2)) ORDER BY 1),
- ARRAY((SELECT unnest($2)::text collate "C" EXCEPT SELECT _parts($1)) ORDER BY 1),
- $3
- );
-$$ LANGUAGE SQL;
Expand Down
8 changes: 4 additions & 4 deletions sql/pgtap.sql.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9986,8 +9986,8 @@ CREATE OR REPLACE FUNCTION partitions_are( NAME, NAME, NAME[], TEXT )
RETURNS TEXT AS $$
SELECT _are(
'partitions',
ARRAY(SELECT _parts($1, $2) EXCEPT SELECT unnest($3)),
ARRAY(SELECT unnest($3) EXCEPT SELECT _parts($1, $2)),
ARRAY((SELECT _parts($1, $2)::text collate "C" EXCEPT SELECT unnest($3)) ORDER BY 1),
ARRAY((SELECT unnest($3)::text collate "C" EXCEPT SELECT _parts($1, $2)) ORDER BY 1),
$4
);
$$ LANGUAGE SQL;
Expand All @@ -10006,8 +10006,8 @@ CREATE OR REPLACE FUNCTION partitions_are( NAME, NAME[], TEXT )
RETURNS TEXT AS $$
SELECT _are(
'partitions',
ARRAY(SELECT _parts($1) EXCEPT SELECT unnest($2)),
ARRAY(SELECT unnest($2) EXCEPT SELECT _parts($1)),
ARRAY((SELECT _parts($1)::text collate "C" EXCEPT SELECT unnest($2)) ORDER BY 1),
ARRAY((SELECT unnest($2)::text collate "C" EXCEPT SELECT _parts($1)) ORDER BY 1),
$3
);
$$ LANGUAGE SQL;
Expand Down
4 changes: 2 additions & 2 deletions test/sql/partitions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,9 @@ SELECT * FROM check_test(
'partitions_are( hidden tab, parts, desc )',
'hi',
' Missing partitions:
not_hidden_part3
"hide.hidden_part1"
"hide.hidden_part2"
"hide.hidden_part1"'
not_hidden_part3'
);

-- Should not work for unpartitioned but inherited table
Expand Down