Conversation
| params['country'] = sys.argv[4] | ||
| if len(sys.argv) == 6: | ||
| params['num_results'] = sys.argv[5] if sys.argv[5] else None | ||
| params['num_results'] = sys.argv[5] or None |
There was a problem hiding this comment.
Function test_query refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity)
| if self.engine: | ||
| if not 'engine' in self.params_dict: | ||
| self.params_dict['engine'] = self.engine | ||
| if self.engine and 'engine' not in self.params_dict: | ||
| self.params_dict['engine'] = self.engine |
There was a problem hiding this comment.
Function SerpApiClient.construct_url refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs) - Simplify logical expression using De Morgan identities (
de-morgan)
| self.params_dict = {} | ||
| self.params_dict["output"] = "json" | ||
| self.params_dict = {"output": "json"} |
There was a problem hiding this comment.
Function SerpApiClient.get_location refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.60%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: