ASoC: SOF: ipc4-pcm: new spcm_dbg_ratelimited() wrapper and use it for inaccurate delay print #5538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
kv2019i
previously approved these changes
Sep 18, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Typo in commit, otherwise good.
| */ | ||
| #define spcm_dbg(__spcm, __dir, __fmt, ...) \ | ||
| dev_dbg((__spcm)->scomp->dev, "pcm%u (%s), dir %d: " __fmt, \ | ||
| (__spcm)->pcm.pcm_id, (__spcm)->pcm.pcm_name, __dir, \ |
ujfalusi
force-pushed
the
peter/sof/pr/innacurate-pcm-delay-print
branch
from
790c564 to
e7ae91a
Compare
Collaborator
Author
|
Changes since v1:
|
bardliao
previously approved these changes
Sep 22, 2025
ranj063
reviewed
Sep 22, 2025
sound/soc/sof/ipc4-pcm.c
Outdated
| dev_dbg_ratelimited(sdev->dev, | ||
| "inaccurate delay, host %llu dai_cnt %llu", host_cnt, dai_cnt); | ||
| spcm_dbg_ratelimited(spcm, substream->stream, | ||
| "inaccurate delay, host %llu dai_cnt %llu", host_cnt, |
Collaborator
There was a problem hiding this comment.
do you have an alignment issue here?
Collaborator
Author
There was a problem hiding this comment.
that is odd as locally it looks OK, but not in the patch...
ujfalusi
force-pushed
the
peter/sof/pr/innacurate-pcm-delay-print
branch
from
e7ae91a to
f2aae3b
Compare
Collaborator
Author
|
Changes since v2:
|
Add dev_dbg_ratelimited() wrapper for snd_sof_pcm specific debug prints that needs rate limited. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
use the new spcm_dbg_ratelimited(), the patch needs to be picked and sent alongside of this... spcm prints help to add context, so we know which PCM reports the incorrect delay. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
kv2019i
approved these changes
Sep 24, 2025
bardliao
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add context:
before:
snd_sof:sof_ipc4_pcm_pointer: sof-audio-pci-intel-mtl 0000:00:1f.3: inaccurate delay, host 256 dai_cnt 119474
after:
snd_sof:sof_ipc4_pcm_pointer: sof-audio-pci-intel-mtl 0000:00:1f.3: pcm5 (HDMI1), dir 0: inaccurate delay, host 256 dai_cnt 119474
The series for the delay fixes will need to pick this first patch for upstream.