ASoC: SOF: ipc4-topology: Fixes for exotic format handling for DMIC and SSP #5559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as well With the introduction of 8-bit formats the DMIC blob lookup also needs to be modified to prefer the 32-bit blob when 8-bit format is used on FE. At the same time we also need to make sure that in case 8-bit format is used, but only 16-bit blob is available for DMIC then we will not try to look for 8-bit blob (which is invalid) as fallback, but for a 16-bit one. Fixes: c04c2e8 ("ASoC: SOF: ipc4-topology: Add support for 8-bit formats") Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
SSP/DMIC blobs have no support for FLOAT type, they are using S32 on data bus. Convert the format from FLOAT_LE to S32_LE to make sure that the correct format is used within the path. FLOAT conversion will be done on the host side (or within the path). Fixes: f7c4191 ("ASoC: SOF: ipc4-topology: Add support for float sample type") Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
bardliao
approved these changes
Oct 20, 2025
singalsu
approved these changes
Oct 20, 2025
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
Thanks, this fixes the FLOAT_LE capture issue for PCH DMIC.
kv2019i
approved these changes
Oct 21, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
The logic around blobs starts to be quite exotic as well. I had to reread the patch a few times, but it does look solid.
jsarha
approved these changes
Oct 21, 2025
ranj063
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the introduction of 8-bit and FLOAT formats missed updating the code responsible for the NHLT blob lookup and selection for DMIC and SSP.
Before these exotic formats we had only 16-bit or 32-bit formats and this needs to be changed to be able to select the correct blob for the configuration.
We also need to make sure that the format is corrected (FLOAT is not supported in blobs for example).
This set updates the blob lookup and allows more formats to be used on the FE side against DMIC or SSP.