-
Notifications
You must be signed in to change notification settings - Fork 349
Topology2: Add sof-hda-generic sereies topologies for DAX #10472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can one of the admins verify this patch?
|
|
test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question from me, @bardliao will need your guidance here for HDA topologies.
| EFX_HDA_MIC_TDFB_PARAMS=line2_pass,EFX_HDA_MIC_DRC_PARAMS=passthrough" | ||
|
|
||
| "sof-hda-generic\;sof-hda-generic-dax\;HDA_CONFIG=dax,HDA_MIC_ENHANCED_CAPTURE=true,\ | ||
| EFX_HDA_MIC_TDFB_PARAMS=line2_pass,EFX_HDA_MIC_DRC_PARAMS=passthrough,DOLBY_DAX_CORE_ID=0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want the default core ID to be > 0 if DAX needs a guaranteed minimum MCPS as core 0 is used for all low latency pipes and RTOS features on HDA topologies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with DOLBY_DAX_CORE_ID=1.
Added: sof-hda-generic-dax.tplg sof-hda-generic-2ch-dax.tplg sof-hda-generic-cavs25-2ch-dax.tplg sof-hda-generic-ace1-2ch-dax.tplg sof-hda-generic-ace3-2ch-dax.tplg Signed-off-by: Jun Lai <jun.lai@dolby.com>
a28c8ae to
68fcf1a
Compare
| DEEP_BUFFER_PIPELINE_SINK 'mixout.2.1' | ||
| DEEP_BUFFER_PCM_NAME 'Deepbuffer HDA Analog' | ||
| HDA_ANALOG_CAPTURE_RATE 48000 | ||
| HDA_ANALOG_PLAYBACK_RATE 48000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: The indentation is weird. Can we always use tab instead of space?
|
|
||
| "sof-hda-generic\;sof-hda-generic-2ch-dax\;HDA_CONFIG=dax,NUM_DMICS=2,\ | ||
| DMIC0_ENHANCED_CAPTURE=true,EFX_DMIC0_TDFB_PARAMS=line2_generic_pm10deg,\ | ||
| EFX_DMIC0_DRC_PARAMS=dmic_default,DOLBY_DAX_CORE_ID=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kv2019i I think we need PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-generic-2ch-dax.bin,\ to include the DMIC NHL as DMIC is enabled, right?
Added:
sof-hda-generic-dax.tplg
sof-hda-generic-2ch-dax.tplg
sof-hda-generic-cavs25-2ch-dax.tplg
sof-hda-generic-ace1-2ch-dax.tplg
sof-hda-generic-ace3-2ch-dax.tplg