Tools: Tune: TDFB: Add generate of few needed blobs #9147
Conversation
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Can we have a ```sof`-`` prefix for all tools and put the tools in the module directories.
Yep, maybe I should postpone this and do the tools move first. There will be a bit more blobs add later, e.g. a blob for analog mic DRC. |
|
Release reminder - one week to v2.11-rc1. |
|
FYI @singalsu , pushing to v2.12. |
This patch adds a few blobs generate for the beamformer. There is no need to update the blobs in tplg2 since the update has been already done with run of an earlier version of this patch. - Support two mic line array with 74 mm spacing with addition to sof_example_line_array.m and sof_example_two_beams.m - Updates beamformer pass-through configuration blob with steer angle to avoid initialize error. - Adds script sof_example_two_beams_default.m to export generic blobs for 2 and 4 mic line arrays. The parameters are such that the array mic spacing is not critical (delay-and-sum type) and narrow user faced stereo beams. The two beams design functions are split to own files for use from two scripts. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tune_tdfb_generic_blobs_export
branch
from
3cc4402 to
fc21c47
Compare
This change adds generate of multi-microphone beamformer blobs to apply with UCM2 rules for SOF. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, but we may want something in the beamformer Readme.md that describes the tool and usage.
Yep, I added it in the 3rd commit. |
singalsu
force-pushed
the
tune_tdfb_generic_blobs_export
branch
from
71c3698 to
abe580e
Compare
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Excellent inline docs and README file on top! No blockers.
src/audio/tdfb/tune/README.md
Outdated
| @@ -0,0 +1,41 @@ | |||
| # Settings blobs generators for TDFB | |||
|
|
|||
| This directory contains the scripts to generate settgings blobs for | |||
This patch adds a README.md file that explains how various blob generate scrips are used. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tune_tdfb_generic_blobs_export
branch
from
abe580e to
5f7e422
Compare
|
sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Known+PR+Failures%22+ |
3 participants
See commit texts for descriptions.