ipc4: copier: unused code cleanup #9701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-katsyuba-intel
requested review from
RanderWang,
abonislawski and
pblaszko
as code owners
serhiy-katsyuba-intel
force-pushed
the
endp_cleanup
branch
from
fb78dee to
ba075c6
Compare
lgirdwood
approved these changes
Dec 2, 2024
ranj063
approved these changes
Dec 3, 2024
Collaborator
ranj063
left a comment
ranj063
left a comment
There was a problem hiding this comment.
looks good except for a minor nit
The use of intermediate endpoint buffer was removed from gateways some time ago. However, the IPC gateway code still contained logic that unnecessarily creates such endpoint buffer. That code has now been removed. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
The use of endpoint buffers in gateways was removed some time ago. endpoint_buffer[] is a leftover from an earlier refactoring, is not used, and can be removed. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
The endpoint[] array is never initialized and is not really used. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
force-pushed
the
endp_cleanup
branch
from
ba075c6 to
14630dd
Compare
abonislawski
approved these changes
Dec 3, 2024
Collaborator
|
sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Known+PR+Failures%22+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipc4: ipcgtw: code cleanup
The use of intermediate endpoint buffer was removed from gateways some time ago. However, the IPC gateway code still contained logic that unnecessarily creates such endpoint buffer. That code has now been removed.
ipc4: copier: remove unused endpoint_buffer[]
The use of endpoint buffers in gateways was removed some time ago. endpoint_buffer[] is a leftover from an earlier refactoring, is not used, and can be removed.
ipc4: copier: remove unused endpoint[]
The endpoint[] array is never initialized and is not really used.