Skip to content

fix(httpx): use default transport as base #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggresillion merged 1 commit into from
Dec 3, 2025
Merged

fix(httpx): use default transport as base #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions httpx/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,23 @@ import (
// Deprecated: use NewClient instead
// nolint
var DefaultClient = &http.Client{
Timeout: time.Minute * 15,
Transport: &http.Transport{
Dial: (&net.Dialer{
Timeout: 20 * time.Second,
}).Dial,
TLSHandshakeTimeout: 15 * time.Second,
},
Timeout: time.Minute * 15,
Transport: NewTransport(),
}

//nolint:exhaustruct // we don't need all fields
func NewClient() *http.Client {
return &http.Client{
Timeout: time.Minute * 15,
Transport: &http.Transport{
Dial: (&net.Dialer{
Timeout: 20 * time.Second,
}).Dial,
TLSHandshakeTimeout: 15 * time.Second,
},
Timeout: time.Minute * 15,
Transport: NewTransport(),
}
}

func NewTransport() *http.Transport {
transport := http.DefaultTransport.(*http.Transport).Clone()
transport.DialContext = (&net.Dialer{
Timeout: 20 * time.Second,
}).DialContext
transport.TLSHandshakeTimeout = 15 * time.Second
return transport
}
Loading