Move pruning folder code to separate feature branch#476
Merged
gregorbg merged 1 commit intothewca:masterfrom Jan 8, 2020
Merged
Move pruning folder code to separate feature branch#476gregorbg merged 1 commit intothewca:masterfrom
gregorbg merged 1 commit intothewca:masterfrom
Conversation
Member
Author
|
Retry after merging #477 |
Member
Author
|
Okay, only reasonable fix seems to be brute force retry for now :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, we create an empty folder that is unused, because pruning is only (subject to being) added in #461
Until the .15 releases, this folder used to be necessary for resources. But now, we can access these directly from within the JAR so we should not create an empty folder.
Merging as soon as Travis says Yes because this is only moving "dead code" to another branch that will then be reviewed again more thoroughly.