Add two new helper functions to format AttemptResults#30
Add two new helper functions to format AttemptResults#30FinnIckler wants to merge 9 commits intothewca:masterfrom
Conversation
|
I'll make a PR to upgrade the CI from node 14... |
Pull Request Test Coverage Report for Build 7957700406Details
💛 - Coveralls |
There was a problem hiding this comment.
An edge case that I frequently run into is that "time" is different depending on FMC single vs average. For example 29 is an FMC single score result and 2933 is an FMC average score result. This needs to be taken into account for them to render properly.
There was a problem hiding this comment.
That is true, I based this function on https://github.com/thewca/worldcubeassociation.org/blob/d3338d0175c608eb34bc1d3be60034cf0ac44e46/WcaOnRails/app/webpacker/lib/utils/edit-events.js#L99 where AttemptResults can't be an average. AttemptResultQualification can though, so if we want to use the method for that also I can change it.
| } | ||
|
|
||
| /** | ||
| * Converts Centiseconds to a human-readable string like "5:30 minutes" |
There was a problem hiding this comment.
"5:30 minutes" doesn't actually make much sense...what's the use case here?
I would expect "5 seconds" or "10 minutes" or "5:30" but in English, I would read the original as "5 minutes and 30 seconds minutes"
Localization should somehow be taken into account for a library like this but I'm not sure if localization makes sense here...
There was a problem hiding this comment.
yeah sorry that comment doesn't make sense, it's 5 minutes and 30 seconds
| * @param word | ||
| * @param options | ||
| */ | ||
| export function pluralize({ count, word, options = {} }: PluralizeParams) { |
There was a problem hiding this comment.
I wouldn't export this function, there's libraries out there that specialize in this use-case.
There was a problem hiding this comment.
I just exported it for testing. How do we do that?
3 participants
We need this function both in the monolith and in wca-registrations to format AttemptResults (in cutoffs and qualifications)