Skip to content

unify the handling of sysconfig/defaults in params #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
igalic wants to merge 2 commits into
base: master
Choose a base branch
from
Open

unify the handling of sysconfig/defaults in params #52

igalic wants to merge 2 commits into from

Conversation

@igalic
Copy link
Contributor

@igalic igalic commented May 21, 2015

unify, and simplify.

@igalic
Copy link
Contributor Author

igalic commented May 21, 2015

i've updated the handling of spec tests, and, moving forward will be basing my changes on this branch.
i'd really love to get some feedback /cc @thias and co.

i also wanna merge @jaggededgedjustice and add rspec tests to it.

petems added a commit to petems/puppet-libvirt that referenced this pull request Jul 10, 2017
@petems
Creating petems-libvirt fork
0e777e5 
Merging these PR's that fix issues for me:
* thias#64
* thias#52
* thias#63
* Moves tests/ to examples/
* Changes meta-data to my fork petems-libvirt
* Eventually use the Vox Pupuli fork:
  * thias#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@igalic