End time default value #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulintrognon
suggested changes
Jan 25, 2021
| ); | ||
| }; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
This example is not related to the rest of the PR. I would advise against it.
| fireEvent.click(getByRole('button')); | ||
|
|
||
| act(() => { | ||
| jest.advanceTimersByTime(30000); |
There was a problem hiding this comment.
You need to advance time by more than 30000 to really test that the timer will stop at 0. I would replace 30000 by 40000 for example.
| onTimeOver, | ||
| onTimeUpdate, | ||
| step = 1, | ||
| timerType = 'INCREMENTAL', |
There was a problem hiding this comment.
I would keep the alphabetical order of properties, to keep the author's logic.
|
Hey, can we push this? Should I fix the reviews? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endTimevalue changes depending on timer mode