refactor: use maps.Copy for cleaner map handling

[fengyuchuanshen]

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Summary by CodeRabbit

• Refactor
  • Streamlined internal data merging logic using a standard library utility, reducing boilerplate and improving maintainability with no change to behavior or public interfaces.
  • Minor efficiency and readability improvements in block aggregation paths.
• Chores
  • No user-facing changes; existing functionality continues to work as before.

[coderabbitai]

Walkthrough

Replaced a manual map copy loop with maps.Copy in GetFullBlocks and added the corresponding maps import. No changes to function signatures or control flow.

Changes

Cohort / File(s)	Summary of Changes
S3 source map copy refactor internal/source/s3.go	Added import for standard library maps; replaced per-entry copy loop into resultMap with maps.Copy(resultMap, fileResults) in GetFullBlocks; no error handling or control-flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "refactor: use maps.Copy for cleaner map handling" accurately and concisely describes the primary change in this PR (replacing a manual per-entry map copy with maps.Copy in GetFullBlocks within internal/source/s3.go), is a single clear sentence, and contains no noisy or vague language.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

internal/source/s3.go (2)

225-226: Optional: preallocate resultMap capacity

Minor perf/readability win: initialize with expected size to reduce map growth.

- resultMap := make(map[uint64]rpc.GetFullBlockResult)
+ resultMap := make(map[uint64]rpc.GetFullBlockResult, len(blockNumbers))

---

94-96: Comment/value mismatch for MaxCacheSize default

The code sets 5 GiB, but the comment says “Increased from 5GB to 10GB”. Fix the comment or the value.

- cfg.MaxCacheSize = 5 * 1024 * 1024 * 1024 // Increased from 5GB to 10GB
+ cfg.MaxCacheSize = 5 * 1024 * 1024 * 1024 // Default 5 GiB

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bd3eca1 and 1dc2c86.

📒 Files selected for processing (1)

• internal/source/s3.go (2 hunks)

🔇 Additional comments (2)

internal/source/s3.go (2)

259-259: Good swap to maps.Copy — same semantics, cleaner code

Copying fileResults into resultMap with maps.Copy mirrors the previous for-range behavior, including overwriting on duplicate keys. Looks good.

---

10-10: No action needed — Go ≥ 1.21 confirmed. go.mod sets "go 1.23.0" and the GitHub Actions workflows use go-version '1.23', so importing "maps" is supported.