fix: broken build with new mermaid feature#63
Merged
this-is-tobi merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the mermaid plugin integration that was causing a broken build after adding
vitepress-plugin-mermaidsupport.The root cause was that
withMermaid()was previously called on the serialized VitePress config (viaJSON.stringify), which silently dropped all functions and Vite plugins. A follow-up attempt using a generatedimport { withMermaid }with an absolute path in the output config was fragile (pnpm strict resolution, machine-specific store paths).The fix moves the
withMermaidcall into thebuildcommand itself, using VitePress's publiconAfterConfigResolvehook. This ensures mermaid is applied at docpress runtime where the import resolves correctly, and the generated config stays as pure serializable JSON.Type of change
How Has This Been Tested?
The fix is covered by unit tests in
src/commands/build.spec.ts:withMermaidis called viaonAfterConfigResolvewith the resolved site config.vitepressBuildcall signature with theonAfterConfigResolveoption.Test Configuration:
Checklist: