-
Notifications
You must be signed in to change notification settings - Fork 183
Update Simple_Patch_Antenna.py #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
modified to use matplotlib.pyplot instead of pylab
|
Hello @VolkerMuehlhaus, in principle I agree with this change. But I guess if we do this, we should do all tutorials together? |
Hi Thorsten @thliebig, [x] done You might want to double check, I tested all examples here on Windows. The axis gridlines are not always nice, but I didn't know change that. BR, Volker |
Has anything changed? I mean pylab was only a shortcut for matplotlib.pyplot but all the method used ultimately should not have changed at all now? Thus I would not expect any visible change to the plots? This is maybe my only remaining issue with this PR, that both commit messages are a bit misleading... |
Restored the formatted labels/captions, with proper escape characters
Yes, the sometimes ugly scale existed before, I left this unchanged. Now back from vacation, I updated all sources again to restore the exact format of captions/labels, but without these errors: by \\ instead of r-string used before. One other detail that I considered changing (but did not change) is the debug switch for showing the model/mesh in AppCSXCAD. In the forum I see many new users who completely miss the importance of checking the mesh lines,so my persomal preference would be to always show the model & mesh. Naming that switch "debug" is misleading in my opinion, but never mind, you are the project owner so it's up to you. TL;DR: All models show similar plots now, but using matplotlib.pyplot instead of pylab |
|
@thliebig push :-) |
Modified to use matplotlib.pyplot instead of outdated pylab