Skip to content

prevent OnCompleteFunc called before last retry#30

Open
hurngchunlee wants to merge 3 commits intothoas:masterfrom
hurngchunlee:master
Open

prevent OnCompleteFunc called before last retry#30
hurngchunlee wants to merge 3 commits intothoas:masterfrom
hurngchunlee:master

Conversation

@hurngchunlee
Copy link

Hi @thoas,

First of all, thank you for creating this useful library for task scheduling.

I noticed that the queue.OnCompleteFunc is triggered before the last retry takes place. After checking the source code, I think the changes in this pull request will prevent it to happen.

Cheers, Hong

hurngchunlee and others added 2 commits May 24, 2021 16:30
Finished task should have `MaxRetries` less than zero.
@hurngchunlee
Copy link
Author

@thoas sorry for taking so long to get back to the failure of the test, was busy on other projects. The failure was due to the fact that the finished task should have the MaxRetries less than zero (or equal to -1) and therefore I update the test case in task_test.go. Could you please have another look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant