nl-cls-delete: tolerate NLE_OBJ_NOTFOUND from cascaded kernel deletion#454
Open
wxmzy88 wants to merge 1 commit intothom311:mainfrom
Open
nl-cls-delete: tolerate NLE_OBJ_NOTFOUND from cascaded kernel deletion#454wxmzy88 wants to merge 1 commit intothom311:mainfrom
wxmzy88 wants to merge 1 commit intothom311:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a u32 classifier, the kernel cascades the deletion of child objects (hash tables and match rules) when the root node is removed via u32_destroy().
Since nl-cls-delete iterates a pre-fetched list of matching entries, subsequent rtnl_cls_delete() calls for already-removed children return -NLE_OBJ_NOTFOUND, which the current code treats as a fatal error.
Handle this by catching NLE_OBJ_NOTFOUND in delete_cb() and treating it as non-fatal.
These entries are reported as "Already removed (cascaded)" instead of triggering nl_cli_fatal(). The deleted counter only increments for entries that were actively deleted by this tool, not for entries that were already removed by the kernel as a side effect.
Before:
After:
