Skip to content

Bug #29 issue fixed #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyew-kim wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

Bug #29 issue fixed #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/components/header/HeaderTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,20 @@ const HeaderTable: React.FC<IProps> = ({ columns, lineNumberColumnWidth }) => {
const [display, setDisplay] = React.useState(0);
const [column, setColumn] = React.useState(-1);

const onClick: React.MouseEventHandler<HTMLTableDataCellElement> = React.useCallback(
(evt) => {
evt.preventDefault();
setDisplay(display + 1);
setColumn(parseInt(evt.currentTarget.id));
},
[display]
);
const onClick: React.MouseEventHandler<HTMLTableDataCellElement> =
React.useCallback(
(evt) => {
evt.preventDefault();
setDisplay(display + 1);
setColumn(parseInt(evt.currentTarget.parentElement?.id as string));
},
[display]
);

const tableStyle = React.useMemo(() => ({ left: lineNumberColumnWidth }), [
lineNumberColumnWidth,
]);
const tableStyle = React.useMemo(
() => ({ left: lineNumberColumnWidth }),
[lineNumberColumnWidth]
);

const columnStyle = React.useMemo(
() => ({
Expand All @@ -46,7 +48,6 @@ const HeaderTable: React.FC<IProps> = ({ columns, lineNumberColumnWidth }) => {
className="ac-datagrid--header--main__panel_cell"
id={String(ci)}
key={ci}
onClick={onClick}
style={columnStyle}
>
{column == ci ? (
Expand All @@ -63,7 +64,9 @@ const HeaderTable: React.FC<IProps> = ({ columns, lineNumberColumnWidth }) => {
)}
</>
) : null}
<span>{col.label}</span>
<span onClick={onClick} className="content">
{col.label}
</span>
<Resizer index={ci} col={col} />
</td>
);
Expand Down
6 changes: 3 additions & 3 deletions src/components/resizer/Resizer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from "react";
import debounce from "lodash.debounce";
import { useDatagridDispatch } from "../../context/DatagridContext";
import { ContextActionTypes, IColumn } from "../../@interface";
import { throttle } from "lodash";

interface IProps {
index: number;
Expand All @@ -20,7 +20,7 @@ const Resizer: React.FC<IProps> = ({ index, col }) => {
evt.preventDefault();

const startClientX = evt.clientX;
const mouseMove = debounce((evt: MouseEvent) => {
const mouseMove = throttle((evt: MouseEvent) => {
let newResizerX = offsetX + (evt.clientX - startClientX);
// check limit
if (newResizerX < 0) {
Expand All @@ -30,7 +30,7 @@ const Resizer: React.FC<IProps> = ({ index, col }) => {
}
newResizerPosition = newResizerX;
setOffsetX(newResizerX);
}, 10);
}, 30);
const mouseMoveEnd = () => {
setResizerActive(false);
dispatch({
Expand Down
13 changes: 8 additions & 5 deletions src/style/header.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@
position: absolute;
}

.ac-datagrid--header--main__panel_cell > span.content {
transition: all 0.3s;
&:hover {
opacity: 0.7;
font-size: 14px;
cursor: pointer;
}
}
.ac-datagrid--header--main__panel_cell .arrow_icon {
display: inline-block;
height: 0;
Expand All @@ -58,8 +66,3 @@
.ac-datagrid--header--main__panel_cell .arrow_icon_up {
border-bottom: 5px solid #000;
}

.ac-datagrid--header--main__panel_cell:hover {
background-color: skyblue;
opacity: 0.5;
}