WIP - Adding ascent speed (stats + graph)#1227
Open
redref wants to merge 5 commits intothomaschampagne:developfrom
Open
WIP - Adding ascent speed (stats + graph)#1227redref wants to merge 5 commits intothomaschampagne:developfrom
redref wants to merge 5 commits intothomaschampagne:developfrom
Conversation
From my tests, works better than backoff as triggering a 429 seems to extend the lock period and api usage is not well reported not a neat fix but improve the overall process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
To begin, thank you for this amazing work, from a long time trail runner user ! And new app is just amazing ! Kudos to you 😉
Mostly beginning to enter the codebase as a non-front developer my side. For trail running, it would be nice to have ascent speed, so I tried to integrate it quite successfully for my use.
Now, I need to package this in a neat way, but it seems testsuite are failing my side (even without those changes)
Any help / opinion / missing parts notice would be nice (and yeah, I am not good at JS internals 😉 ).