Improvements in data structure (keywords and image added) and corrections in href logic #12
Open
morissonmaciel wants to merge 5 commits intothomastuts:masterfrom
morissonmaciel:master
Open
Improvements in data structure (keywords and image added) and corrections in href logic #12morissonmaciel wants to merge 5 commits intothomastuts:masterfrom morissonmaciel:master
morissonmaciel wants to merge 5 commits intothomastuts:masterfrom
morissonmaciel:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @thomastuts,
I make some changes in article-extractor to improve de data structure returned from its main
extractArticlefunction.First I included two new attributes:
keywords
Obtained from tags related to "keywords" name and "swiftype > keys" variant (common used in most articles in internet (see. Engadget.com and all Vox Media articles pages)
image
Obtained from two sources: a scored rank from all
<img>from<body>or<main>section.; otherwise from tags related to "swiftype > image" variant.Also, make changes in obtaining
authordata using tags related to "swiftype > blogger_name" variant.The documentation was slightly improved with these new fields and a increment in minor version was made: 1.1.0