Skip to content

Make buf variable static and fix compilation error#166

Open
abique wants to merge 1 commit intothorkill:masterfrom
abique:master
Open

Make buf variable static and fix compilation error#166
abique wants to merge 1 commit intothorkill:masterfrom
abique:master

Conversation

@abique
Copy link
Copy Markdown

@abique abique commented Nov 11, 2020

No description provided.

@trofi
Copy link
Copy Markdown

trofi commented Jun 5, 2022

To add a bit of colour to this PR.

gcc-10 changed the default from -fcommon to -fno-common: https://gcc.gnu.org/PR85678

As a result build fails as:

ld: stabs-trans.32.o:/build/source/libedfmt/stabs-trans.c:28: multiple definition of `buf'; dwarf2-trans.32.o:/build/source/libedfmt/dwarf2-trans.c:22: first defined here

This PR fixes the failure for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants