lottie-player: replace immediate rendering with render loop#255
Open
lottie-player: replace immediate rendering with render loop#255
Conversation
Remove direct _render() calls and unified render loop handle. related: #251
tinyjin
force-pushed
the
jinny/lottie-render-loop
branch
from
f0a9f71 to
8334f62
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors lottie-player rendering to avoid immediate _render() calls and instead drive drawing via a unified requestAnimationFrame render loop, aiming to address first-load display issues on GPU engines (Issue #251).
Changes:
- Introduces RAF-managed render loop state (
_rafId) and a dirty flag (_dirty) to coordinate rendering. - Replaces direct
_render()calls with_requestRender()in load/seek/resize/quality paths. - Cancels any scheduled RAF on
destroy()and setscurrentStatetoLoadingat the start ofload().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Perf Test preview deployment ready! 📊 Perf Test: https://thorvg-perf-test-h35nrtizi-thorvg-web.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove direct _render() calls and unified render loop handle.
related: #251