-
Notifications
You must be signed in to change notification settings - Fork 28
Rabail branch #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rabail branch #129
Conversation
Oliver-Quail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rabail,
I had a look over your PR and it only needs a few minor changes.
Firstly please add your demo to the DemoProjects/metadata/demos.json file. For more details, please see the guide in this PR
Also you have uploaded some local files that are not needed in SplashKit Online. Please delete these file in the highlighted image and re zip and upload the project

Finally, when testing their was an issue with running the game. This is an issue with the SK Online C# not being fully implemented. I will look into fixing this as it is a complex issue, please don't worry about this.
Overall good first PR :).
Please let me know when you've fixed the above issues and I will be happy to approve :)
|
Hi Oliver,
|
Oliver-Quail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this pr
Description
This pull request adds a new demo project zip file ArrowGamecsharp.zip to the DemoProjects/ folder and removes the previously created (now empty) demo/ folder. This update helps maintain a cleaner project structure and ensures the demo file is correctly placed and accessible.
The demo zip contains a C# SplashKit game showcasing basic player movement using arrow keys. It can serve as a sample project for contributors and learners
How Has This Been Tested?
Testing Checklist
Since this is a static file addition, browser testing is only relevant for download/accessibility.
Checklist