Skip to content

Conversation

@rabail-aamir
Copy link

Description

This pull request adds a new demo project zip file ArrowGamecsharp.zip to the DemoProjects/ folder and removes the previously created (now empty) demo/ folder. This update helps maintain a cleaner project structure and ensures the demo file is correctly placed and accessible.
The demo zip contains a C# SplashKit game showcasing basic player movement using arrow keys. It can serve as a sample project for contributors and learners

How Has This Been Tested?

  • Verified that the file ArrowGamecsharp.zip is properly placed in DemoProjects/ folder
  • Checked file structure in local repo after moving and removing the old folder
  • Confirmed that demo/ no longer exists
  • Validated file upload and visibility on GitHub in the correct folder

Testing Checklist

  • [✓ ] Tested in latest Chrome
  • [✓ ] Tested in latest Safari
  • [✓ ] Tested in latest Firefox

Since this is a static file addition, browser testing is only relevant for download/accessibility.

Checklist

  • [✓] My code follows the style guidelines of this project
  • [✓ ] I have performed a self-review of my own code
  • [✓] I have commented my code in hard-to-understand areas
  • [✓ ] I have made corresponding changes to the documentation
  • [✓ ] My changes generate no new warnings
  • [✓ ] I have requested a review from ... on the Pull Request

Copy link
Collaborator

@Oliver-Quail Oliver-Quail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rabail,
I had a look over your PR and it only needs a few minor changes.
Firstly please add your demo to the DemoProjects/metadata/demos.json file. For more details, please see the guide in this PR
Also you have uploaded some local files that are not needed in SplashKit Online. Please delete these file in the highlighted image and re zip and upload the project
review
Finally, when testing their was an issue with running the game. This is an issue with the SK Online C# not being fully implemented. I will look into fixing this as it is a complex issue, please don't worry about this.

Overall good first PR :).
Please let me know when you've fixed the above issues and I will be happy to approve :)

@rabail-aamir
Copy link
Author

Hi Oliver,
I’ve made the following updates in this branch:

  • Added ArrowGamecsharp.zip to DemoProjects/ with its thumbnail and updated demos.json metadata accordingly.
  • Removed .vscode/settings.json from the repository and added .vscode/ to .gitignore so it won’t be tracked in the future.

Copy link
Collaborator

@Oliver-Quail Oliver-Quail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants