Documentation/routing with servers #622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliver-Quail
requested changes
Aug 8, 2025
Oliver-Quail
left a comment
Oliver-Quail
left a comment
There was a problem hiding this comment.
I approve this PR pending confirmation of testing of OOP code
| - [x] The tutorial is free of spelling and grammatical errors. | ||
| - [x] The tutorial is easy to follow. | ||
| - [x] The tutorial has: | ||
| - [x] C# using top level statements |
There was a problem hiding this comment.
Just checking. It seems from your write up you tested C# code (Object-Oriented Programming) didn't you?
If so please add this to the check list as it was a task requirement to review this code as well
| @@ -0,0 +1 @@ | |||
| contributors:Runqi Liu, Haoyu Liu,Wei Zhang | |||
There was a problem hiding this comment.
I don't think this file is necessary
Oliver-Quail
approved these changes
Aug 12, 2025
Oliver-Quail
left a comment
Oliver-Quail
left a comment
There was a problem hiding this comment.
Requested changes have been made.
I approve this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tutorial review of the tutorial has been done. Modified part of the text description of the sentence to make the content more coherent and clear. The code in this tutorial has been run to ensure that it works and outputs the results.In the HTML file, I added some elements myself to make the page more perfect and easier to operate.
Checks done:
Tested in latest Chrome
Tested in latest Firefox
npm run build
npm run preview
Code Checks:
Checked C#
Checked C++
Checked Python
Code output results:
Prat one
Create a new project folder and enter that folder. We need to set up a resources folder to store the files we want to 'provide services' for. We need to run 'skm resources' in the terminal.
C++
PY
C#
result
Part two
Based on the last time, this uses the next_web_request function to get the next server request, and depending on whether it is obtained, selectively redirects the page to the login page or the homepage (while also using the skm sources command to create a sources file, placing index.html and login.html in the file).
C++
PY
C#
Part three
Based on the documents in the second part, we use a while loop to obtain multiple requests and navigate them to different pages. The function ISGetRequestFor is used to determine if the corresponding request has been received. During this process, a problem was found: for /quit, the server exits directly without giving any prompt, which may confuse users in real use. In practice, we could add a prompt.
C++
PY
C#
C#
Result
