-
Notifications
You must be signed in to change notification settings - Fork 146
Add metadata injection script for Markdown files #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add metadata injection script for Markdown files #626
Conversation
ibi420
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @nouri-devv ,
I've reviewed the script, and it's an excellent addition to the documentation website. It not only helps keep our documentation up to date but also gives the documentation team the ability to identify and remove outdated content, making updates much more efficient.
Thank you for the opportunity to review your work and great job on this contribution
theiris6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve reviewed the document and it’s a clear, well-written contribution. The improvements make the content easier to follow and will be valuable for anyone using the documentation.
Thank you for the effort you’ve put into this update — great job on this contribution!
MillicentAmolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The script update is a really good fix, per my review. Updating pre-build to prebuild ensures that npm executes it correctly.
returnMarcco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nouri-devv,
The script looks good. I've used GitHub Copilot to help with reviewing this, and the overall feedback is that the logic is correct in all methods, and all methods are robust. Graceful fallback logic is implemented in each method, and JSDocs are excellent considering this in plain Javascript.
Well done.
Description
A script that run before building the app and will inject meta data such as Last Updated Date and Last Updated Author using Git's metadata.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested this by building the app and going through all the files that was changed to see if the format is correct.
Tested in in Safari, Chrome and Firefox.
Testing Checklist:
Checklist: