Skip to content

Conversation

@nouri-devv
Copy link

Description

A script that run before building the app and will inject meta data such as Last Updated Date and Last Updated Author using Git's metadata.

Type of change

Please delete options that are not relevant.

  • [x ] New feature (non-breaking change which adds functionality)
  • [ x] Documentation (update or new)

How Has This Been Tested?

Tested this by building the app and going through all the files that was changed to see if the format is correct.
Tested in in Safari, Chrome and Firefox.

Testing Checklist:

  • [ x] Tested in latest Chrome
  • [ x] Tested in latest Safari
  • [ x] Tested in latest Firefox

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have requested a review from ... on the Pull Request

Copy link

@ibi420 ibi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nouri-devv ,

I've reviewed the script, and it's an excellent addition to the documentation website. It not only helps keep our documentation up to date but also gives the documentation team the ability to identify and remove outdated content, making updates much more efficient.

Thank you for the opportunity to review your work and great job on this contribution

Copy link

@theiris6 theiris6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the document and it’s a clear, well-written contribution. The improvements make the content easier to follow and will be valuable for anyone using the documentation.
Thank you for the effort you’ve put into this update — great job on this contribution!

Copy link

@MillicentAmolo MillicentAmolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The script update is a really good fix, per my review. Updating pre-build to prebuild ensures that npm executes it correctly.

Copy link

@returnMarcco returnMarcco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nouri-devv,

The script looks good. I've used GitHub Copilot to help with reviewing this, and the overall feedback is that the logic is correct in all methods, and all methods are robust. Graceful fallback logic is implemented in each method, and JSDocs are excellent considering this in plain Javascript.

Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants