Skip to content

Conversation

@nouri-devv
Copy link

Description

A report based on the google lighthouse performance report.

Type of change

  • [ x] Documentation (update or new)

How Has This Been Tested?

Tested by running and building the app.

Testing Checklist:

  • [ x] Tested in latest Chrome
  • [ x] Tested in latest Safari
  • [ x] Tested in latest Firefox

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have requested a review from ... on the Pull Request

Copy link

@ibi420 ibi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your report is well-structured, clearly highlights areas for improvement, and effectively demonstrates how to run the benchmarking. Well done, and thank you for the opportunity to review your work.

Copy link

@MillicentAmolo MillicentAmolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is relatively easy to read and understand. It provides valuable performance information, highlights areas for improvement, and provides a clear explanation of the tool. Fantastic work!

Copy link

@returnMarcco returnMarcco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nouri-devv,

Well done on the documentation. It's well written, explains the purpose of the document, delves into related metrics, and provides reasoning for the changes. The formatting is spot on in my opinion.

Good work.

Copy link

@WaelAlahamdi WaelAlahamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nouri-devv, I have reviewed the documentation. The report is detailed, presents accurate Lighthouse results for both environments, and outlines clear areas for improvement. Thank you for the work, approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants