-
Notifications
You must be signed in to change notification settings - Fork 129
feat: tutorial self enrolment task feature #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.0.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @b0ink , Please disregard the approval, I have requested changes. Everything in your PR looked fine, but when I tried running the frontend and backend branches locally, I repeatedly encountered database migration errors. Is there any additional setup required to run this correctly? If so, could you please document it? I've attached the screenshots below.
aditya993388
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @b0ink , Everything in your PR looked fine, but when I tried running the frontend and backend branches locally, I repeatedly encountered database migration errors. Is there any additional setup required to run this correctly? If so, could you please document it? I've attached the screenshots below.
Duy-Nguyen1104
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I was able to pull the branch 8.0.x and tested out the self enrolment feature of this pull requests. Initially, when switching branches and re-run dev container, the database wasn't auto filled with test users and courses, and I had to manually run db:init and db:populate in the backend (don't know if this problem happened only on my machine or not).
I was able to enable self tutorial enrolment for tasks and choosing between tutorial streams.

When logged in as student, I noticed that student from the selected streams are auto enrolled in the tutorial enrolment, and I can withdraw from or enrol to which tutorial I choose.

There is just a minor code redundancy in your files changed. Overall, great job!
| expose :scorm_attempt_limit | ||
| expose :tutorial_self_enrolment_enabled | ||
| expose :tutorial_self_enrolment_stream_id | ||
| expose :scorm_attempt_limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line I noticed to be redundant as it is already written on line 50



Description
This feature will allow staff to enable the "Tutorial self enrolment" feature for a designated task. Staff will select which tutorial stream(s) to fetch the tutorials from, and students will be prompted with the list of tutorials they must choose from to complete the task.
How has this been tested?
Ensure you are also using the Front End branch:
thoth-tech/doubtfire-web#306
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration