Skip to content

Conversation

@AB-Deakin
Copy link

Description

Making some changes to the change_remotes.sh script to correct filepath logic to work on multiple operating systems and to ask both origin and upstream with checks to confirm the remotes have changed.

https://github.com/thoth-tech/doubtfire-deploy/blob/main/CONTRIBUTING.md
Step 3 will now work correctly

Fixes #
change_remotes.sh not working on operating systems other than Mac OS and allows for more flexibility on inputs with checks to ensure that the changes to origin and upstream have been made correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran multiple tests to ensure correct origin and upstream are set as well as potential errors to be caught if some repositories are missing and updating text to reflect those changes.

  • Tested in git bash on Windows (My only OS)
  • Tested on Mac
  • Tested on Linux

Checklist

If involving code

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Folders and Files Added/Modified

Please list the folders and files added/modified with this pull request.

  • Modified:
    • doubtfire-deploy/change_remotes.sh

@AB-Deakin
Copy link
Author

01
02
Using the script to successfully change origin and upstream on windows mutliple times.

@AB-Deakin
Copy link
Author

lin1 lin2 lin3 lin4 Also testing script successfully on Linux systems with multiple changes to origins and upstreams.

Copy link

@SahiruWithanage SahiruWithanage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR!
I tested the script and it works perfectly.

What I tested:

  • Script execution and path resolution
  • Remote updates for all submodules
  • Error handling with missing directories
  • Works correctly in Linux environment

Overall, this is a solid improvement that will make the setup process much more reliable across different operating systems. Ready to merge!

Copy link

@ibi420 ibi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I can confirm the implementation supports reliable script execution with proper path resolution, enables remote updating of all submodules, and incorporates robust error handling for scenarios involving missing directories. Functionality has been confirmed in Linux environments.

@AB-Deakin
Copy link
Author

Ready to merge branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants