Skip to content

Conversation

@Duy-Nguyen1104
Copy link

Description

[For the credit points to be correctly implemented, this PR assume that the backend doubtfire-api to have fetched this PR: https://github.com/thoth-tech/doubtfire-api/pull/71 for credit_points attribute to be added to unit model]

This PR implements comprehensive credit points tracking, unit overload functionality, and displaying unit metadata (course name, credit points, level) in unit card.

  • Regarding the credit points component, I have added color-coded progress bars with status indicators (early, moderate, on-track, complete) to help students track their degree completion.
  • Add an overload option for students. A modal dialog will appear when students attempt to add overload units to a trimester, providing educational guidance about overload requirements.
  • Updated unit-card.component.ts to include essential metadata display.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

image
  • Verified overload dialog functionality with proper user flow
  • Tested credit points display correctly upon adding / removing unit from slots

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Edge

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

Copy link

@giangnht19 giangnht19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

I have pulled and successfully tested on my local machine. Good work!

Copy link

@Triet-coder Triet-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1
Tested locally: all good. Keep pushing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants