TRdailyforecast view swift refactor#227
Open
katsuroo wants to merge 5 commits intothoughtbot:masterfrom
Open
Conversation
Contributor
|
Looks like there’s some compile errors on CI: Have you been able to reproduce this locally? It’s strange, because it definitely looks like you’re importing |
sharplet
reviewed
Jan 7, 2019
| @IBOutlet var lowTemperatureLabel: UILabel! | ||
| @IBOutlet var conditionsImageView: UIImageView! | ||
| @IBOutlet var contentView: DailyForecastView! | ||
| @objc public var viewModel: DailyForecastViewModel? { |
Contributor
There was a problem hiding this comment.
Maybe leave an extra line above here to separate this property from the group of @IBOutlet properties?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.