Adjust routes drawing to be compatible with Rails main#336
Adjust routes drawing to be compatible with Rails main#336seanpdoyle merged 1 commit intothoughtbot:mainfrom
Conversation
|
Thanks for opening this @luizkowalski. I should have some time this upcoming Friday to look at this. Since this routing change was reverted once already, we might wait until the change gets included in a release. We should also get this testing against Rails 8, now that that's been released. |
makes sense, I will keep an eye and will come back to it when a new release includes this change
Opened a separated PR for it and will rebase after merged, I think it's best |
|
@luizkowalski could you rebase this onto |
cb96a1e to
950f527
Compare
|
@emilford just did it! sorry about it, completely forgot about this PR, life is a bit crazy at the moment haha |
|
Thank you @luizkowalski! |
high_voltage was the only one that needed upgrading thoughtbot/high_voltage#336
high_voltage was the only one that needed upgrading thoughtbot/high_voltage#336
Some days ago, Rails changed how the routing mapper accept parameters so that it expects keywords instead of hashes.
This PR adjusts High Voltage so that it stops printing deprecation warnings.
All tests should continue to pass