Skip to content

Adjust routes drawing to be compatible with Rails main#336

Merged
seanpdoyle merged 1 commit intothoughtbot:mainfrom
luizkowalski:rails-main-compatibility
Mar 5, 2025
Merged

Adjust routes drawing to be compatible with Rails main#336
seanpdoyle merged 1 commit intothoughtbot:mainfrom
luizkowalski:rails-main-compatibility

Conversation

@luizkowalski
Copy link
Contributor

Some days ago, Rails changed how the routing mapper accept parameters so that it expects keywords instead of hashes.

This PR adjusts High Voltage so that it stops printing deprecation warnings.

All tests should continue to pass

@emilford
Copy link
Contributor

emilford commented Dec 2, 2024

Thanks for opening this @luizkowalski. I should have some time this upcoming Friday to look at this.

Since this routing change was reverted once already, we might wait until the change gets included in a release.

We should also get this testing against Rails 8, now that that's been released.

@luizkowalski
Copy link
Contributor Author

Since this routing change was reverted once already, we might wait until the change gets included in a release.

makes sense, I will keep an eye and will come back to it when a new release includes this change

We should also get this testing against Rails 8, now that that's been released.

Opened a separated PR for it and will rebase after merged, I think it's best

@emilford
Copy link
Contributor

@luizkowalski could you rebase this onto main to test against the latest supported versions.

@luizkowalski luizkowalski force-pushed the rails-main-compatibility branch from cb96a1e to 950f527 Compare February 28, 2025 18:41
@luizkowalski
Copy link
Contributor Author

@emilford just did it! sorry about it, completely forgot about this PR, life is a bit crazy at the moment haha

@seanpdoyle seanpdoyle merged commit efe763d into thoughtbot:main Mar 5, 2025
17 checks passed
@seanpdoyle
Copy link
Contributor

Thank you @luizkowalski!

@luizkowalski luizkowalski deleted the rails-main-compatibility branch March 5, 2025 15:24
edwardloveall added a commit to hotline-webring/hotline-webring that referenced this pull request Jan 19, 2026
high_voltage was the only one that needed upgrading

thoughtbot/high_voltage#336
edwardloveall added a commit to hotline-webring/hotline-webring that referenced this pull request Feb 7, 2026
high_voltage was the only one that needed upgrading

thoughtbot/high_voltage#336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants