-
-
Notifications
You must be signed in to change notification settings - Fork 149
Added Rails 8.0 to the test matrix #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1636a9b
Added Rails 8.0 to the test matrix
luizkowalski 660966b
Added Rails 8.0 to test matrix
luizkowalski 8608b82
It should be one ignore per line
luizkowalski c374d0b
It should be one ignore per line
luizkowalski dfeaee6
Added Rails 7.2 and dropped 6.0
luizkowalski 4675056
Added Rails 7.2 and dropped 6.0
luizkowalski 1640b44
Added activemodel dependency for tests and requiring logger
luizkowalski aec7394
Adding mutex and bigdecimal to the dev/test deps and rails 7.2 to the…
luizkowalski 6d7e650
Re-add 6.0 and add test deps on appraisal file
luizkowalski 6fa2820
Re-add 6.0 and add test deps on appraisal file
luizkowalski 740241e
Fix dependencies
luizkowalski 322124e
Post CR: Drop support for older Ruby/Rails version
luizkowalski 8af3a9d
Delete old gemfiles
luizkowalski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,20 @@ | ||
| rails_versions = %w( | ||
| 6.0 | ||
| 6.1 | ||
| 7.0 | ||
| 7.1 | ||
| 7.2 | ||
| 8.0 | ||
| ) | ||
|
|
||
| rails_versions.each do |version| | ||
| appraise "rails_#{version}" do | ||
| gem "rails", "~> #{version}.0" | ||
| if version == "7.0" | ||
| gem "benchmark" | ||
| gem "bigdecimal" | ||
| gem "drb" | ||
| gem "logger" | ||
| gem "mutex_m" | ||
| end | ||
| gem "rails-controller-testing" | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.