This repository was archived by the owner on Jun 8, 2019. It is now read-only.
Open
Conversation
lib/sudoku_reader.rb
Outdated
Contributor
There was a problem hiding this comment.
@gniquil you could do all this in one step by splitting on the pattern /\D*/ (any number of non-number characters)
I might also move line =~ /^-+/ into a named private method. The line would then look like:
line.split(/\D*/) unless separator_line?
Author
There was a problem hiding this comment.
Great point on both. Thanks for the feedback. I will change them soon.
Frank
lib/sudoku_reader.rb
Outdated
Contributor
There was a problem hiding this comment.
Nice catch there with a regex that will split out both numbers and periods 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.