fix: matrix background gaps and bleed on landing page#25
Open
Conversation
- Replace platform-branched clearRect/clearRects with unified per-box
clearRects that work on both CLI and web (no isBrowser checks)
- Fix logoHeight calculations (4/15/9) to match actual Logo component
heights on both platforms
- Use interior-only clearRects for bordered boxes so matrix shows
through border cells (border chars overwrite matrix directly)
- Add chat area clearRect only when chat fits inline
- Simplify MatrixBackground to single clearRects prop
- Add shouldFill={false} to CLI Logo outer box and "Press o" elements
- Add demo/demo:dev scripts to root package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shouldFill={false}to CLI Logo outer box and "Press o" elementsdemo/demo:devscripts to root package.jsonContext
On CLI, the Zig renderer's
fillRectwith transparent bg preserves existing characters (alpha-blending path), so matrix chars bleed through bordered boxes. On web, transparent fills overwrite chars with spaces. The clearRect system prevents matrix from rendering behind boxes on both platforms without requiring platform checks.Test plan
bun demo:dev landing— verify matrix shows in gaps between boxes and doesn't bleed into them (CLI)bun dev— verify same on web, including when boxes wrap on narrow viewports