Fix page scroll blocked when hovering over terminal demo#33
Merged
to-be-coder merged 1 commit intomainfrom Mar 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e.preventDefault(), which blocked native page scrolling whenever the mouse was over a gridland canvas (e.g. the terminal demo on the docs site)preventDefault()call and switched to a passive wheel listener, so page scroll works normally while TUI scroll events still dispatch to renderablesFuture consideration
If a component needs to own scroll (e.g. a scrollable list or chat window), it should opt in by calling
event.preventDefault()on the TUI MouseEvent in its scroll handler. The browser-renderer can then checktuiEvent.defaultPreventedand conditionally block page scroll. This keeps the default behavior permissive and avoids breaking page scroll for components that don't need it.Test plan
🤖 Generated with Claude Code