Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

Add maxlength attribute for the inputs on the project and fix one small integration test. #13

Open
ronualdo wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add maxlength attribute for the inputs on the project and fix one small integration test. #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a892f8
remove comments from ngo index erb
ronualdo Oct 16, 2013
a1d184b
include maxlength attribute to reserve inputs form
ronualdo Oct 16, 2013
47489e7
add maxlength attribute for inputs in receipt form
ronualdo Oct 16, 2013
447298f
add maxlength attributes to new bill form inputs
ronualdo Oct 16, 2013
ab64590
add maxlength attribute for update bill form inputs
ronualdo Oct 16, 2013
d068a04
add an id to language links as a fix to tests failures
ronualdo Oct 16, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions views/bills/new.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<form id='new_bill' method="post" action="/bill/create" enctype="multipart/form-data">
<label for="issued_by"><%= I18n.t(:issued_by) %></label>
<input name="issued_by" type="text" required autofocus />
<input name="issued_by" maxlength="200" type="text" required autofocus />

<label for="due_date"><%= I18n.t(:due_date) %></label>
<input id="datepicker" name="due_date" type="text" placeholder="<%= I18n.t(:date_format) %>" required />
Expand All @@ -24,12 +24,12 @@
<span class="prefix">R$</span>
</div>
<div class="small-10 columns">
<input name="total_amount" type="number" min="0.1" step="any" required />
<input name="total_amount" maxlength="100" type="number" min="0.1" step="any" required />
</div>
</div>

<label for="barcode"><%= I18n.t(:barcode) %></label>
<input name="barcode" type="text" required />
<input name="barcode" maxlength="300" type="text" required />

<label for="image"><%= I18n.t(:image) %></label>
<input name="image" type="file" />
Expand Down
4 changes: 2 additions & 2 deletions views/bills/reserve.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
<form method="post" action="<%= @action %>">
<div class="form-group">
<label for="phone_number"><%= I18n.t(:phone_number) %></label>
<input name="phone_number" type="text" autofocus class="form-control">
<input name="phone_number" maxlength="20" type="text" autofocus class="form-control">
</div>
<div class="form-group">
<label for="email"><%= I18n.t(:email) %></label>
<input name="email" type="text" required value="<%= session['email']%>" class="form-control">
<input name="email" maxlength="100" type="text" required value="<%= session['email']%>" class="form-control">
</div>


Expand Down
4 changes: 2 additions & 2 deletions views/bills/update.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<form id='update_bill' method="post" action="/bill/update/<%= @bill.id %>" enctype="multipart/form-data">
<label for="issued_by"><%= I18n.t(:issued_by) %></label>
<input name="issued_by" type="text" required autofocus value="<%= @bill.issued_by %>" />
<input name="issued_by" maxlength="200" type="text" required autofocus value="<%= @bill.issued_by %>" />

<label for="due_date"><%= I18n.t(:due_date) %></label>
<input id="datepicker" name="due_date" type="text" placeholder="<%= I18n.t(:date_format) %>" value="<%= I18n.l @bill.due_date %>" required />
Expand All @@ -25,7 +25,7 @@
<span class="prefix">R$</span>
</div>
<div class="small-10 columns">
<input name="total_amount" type="number" min="0.1" step="any" value="<%= @bill.total_amount %>" required />
<input name="total_amount" maxlength="200" type="number" min="0.1" step="any" value="<%= @bill.total_amount %>" required />
</div>
</div>

Expand Down
4 changes: 2 additions & 2 deletions views/layout.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
<a href="/auth" id="login_with_google" class="login-link">Login with Google</a>
<% end %>

<a class="link-lang" href="/locale/pt">
<a id="link-pt" class="link-lang" href="/locale/pt">
<img src="/img/brazil_flag.png" alt="Versão em Português">
</a>
<a class="link-lang" href="/locale/en">
<a id="link-en" class="link-lang" href="/locale/en">
<img src="/img/usa_flag.png" alt="English Version">
</a>
</div>
Expand Down
54 changes: 0 additions & 54 deletions views/ngo/index.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,60 +81,6 @@
<%= I18n.t("upload_receipt") %>
</a>
</div>



<!-- <div>
<a href="#" class="th radius <%= bill.status %>" data-reveal-id="myModal<%= bill.id %>">
<img class="center" src="<%= bill.url %>" alt="<%= bill.filename %>" />
<p class="issued-by"><%= bill.issued_by %></p>
<p class="total_amount">R$ <%= bill.total_amount %></p>
</a>

<div class="text-center">
<% if bill.status == :opened %>
<a href="/bill/reserve/<%= bill.id %>" class="tiny button">
<%= I18n.t("reserve_bill") %>
</a>
<% end %>
<a href="/bills/<%= bill.id %>/receipts/new" class="tiny button">
<%= I18n.t("upload_receipt") %>
</a>
</div>
</div>
-->


<!-- <section class="reveal-modal small-12" id="myModal<%= bill.id %>">
<a class="close-reveal-modal">&#215;</a>
<div class="small-8">
<h4><%= bill.issued_by %></h4>
<p>R$ <%= bill.total_amount %></p>
<p class="due_date" data-timestamp="<%=bill.due_date.to_time.to_i%>"><%= I18n.l bill.due_date %></p>
<p><%= bill.barcode %></p>
</div>
<div>
<a href="<%= bill.url %>" >
<img class="small-4" src="<%= bill.url %>" alt="<%= bill.filename %>"/>
</a>
</div>
<% if logged_as_admin? %>
<div class="row text-center">
<form id='remove_bill_form' method="post" action="/bill/remove/<%= bill.id %>" enctype="multipart/form-data">
<a href="/bill/update/<%= bill.id %>" class="tiny button"><%= I18n.t("update_bill_button") %></a>
<input name="_method" type="hidden" value="delete">
<button type="submit" class="tiny button" onclick="return confirm('<%= I18n.t("confirm_remove")%>')">
<%= I18n.t("remove_bill")%>
</button>
<% if bill.status == :waiting_confirmation %>
<a href="/bill/close/<%= bill.id %>" class="tiny button"><%= I18n.t("close_bill") %></a>
<% end %>
</form>
</div>
<% end %>
</section> -->


</li>
<% end %>
</ul>
Expand Down
4 changes: 2 additions & 2 deletions views/receipts/new.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
<form method="post" action="/bills/<%= @bill.id %>/receipts/create" enctype="multipart/form-data">
<div class="form-group">
<label for="contributor_name"><%= I18n.t(:name) %></label>
<input name="contributor_name" type="text" autofocus value="<%= session['name']%>" class="form-control">
<input name="contributor_name" maxlength="200" type="text" autofocus value="<%= session['name']%>" class="form-control">
</div>

<div class="form-group">
<label for="contributor_email"><%= I18n.t(:email) %></label>
<input name="contributor_email" type="text" required value="<%= session['email']%>" class="form-control">
<input name="contributor_email" maxlength="100" type="text" required value="<%= session['email']%>" class="form-control">
</div>

<div class="form-group">
Expand Down