Adds typed uniforms to ShaderMaterial and RawShaderMaterial#1579
Open
haxiomic wants to merge 4 commits intothree-types:masterfrom
Open
Adds typed uniforms to ShaderMaterial and RawShaderMaterial#1579haxiomic wants to merge 4 commits intothree-types:masterfrom
haxiomic wants to merge 4 commits intothree-types:masterfrom
Conversation
Add optionally typed uniforms to ShaderMaterial
Author
|
I'll add Defines types before this is complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using this for years in my own projects where I use custom shaders often. Typing uniforms makes working with these classes much nicer
This does not change the behaviour of existing code because uniform types default to
any