This repository was archived by the owner on Jul 20, 2021. It is now read-only.
add certmagic package to host explorer frontend with https#511
Open
DylanVerstraete wants to merge 2 commits intomasterfrom
Open
add certmagic package to host explorer frontend with https#511DylanVerstraete wants to merge 2 commits intomasterfrom
DylanVerstraete wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
I like the certmagic integration but not the hardcoding of LetsEncryptStagingCA Ca and the port, it also uses a different domain/port now than the explorer rest api, it would be better if they can be both served by the same port and domain+port |
Contributor
Author
|
Added flags to
It also now serves the frontend and backend on the same host/port. Needs to be tested in production right now. |
Contributor
|
@LeeSmet please give a proper review of this PR ASAP. |
1 task
9533ecf to
1ff618c
Compare
58ae02f to
9e641e8
Compare
f4a600f to
e8e17e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #505
Example of how to integrate in Tfchain: