Merge pull request #99 from threshold-network/ackchyually

Staking `requestAuthorizationDecrease` function contract update

Author: cygnusv

contracts/staking/IApplication.sol

@@ -48,6 +48,9 @@ interface IApplication {
     ///         pending decrease and respond to the staking contract with
     ///         `approveAuthorizationDecrease` at its discretion. It may
     ///         happen right away but it also may happen several months later.
+    ///         If there is already a pending authorization decrease request
+    ///         for the application, and the application does not agree for
+    ///         overwriting it, the function should revert.
     function authorizationDecreaseRequested(
         address stakingProvider,
         uint96 fromAmount,

contracts/staking/IStaking.sol

@@ -110,7 +110,9 @@ interface IStaking {
     ///         it happens depends on the application. Can only be called by the
     ///         given staking provider’s authorizer. Overwrites pending
     ///         authorization decrease for the given staking provider and
-    ///         application.
+    ///         application if the application agrees for that. If the
+    ///         application does not agree for overwriting, the function
+    ///         reverts.
     /// @dev Calls `authorizationDecreaseRequested(address stakingProvider, uint256 amount)`
     ///      on the given application. See `IApplication`.
     function requestAuthorizationDecrease(

contracts/staking/TokenStaking.sol

@@ -1281,7 +1281,9 @@ contract TokenStaking is Initializable, IStaking, Checkpoints {
     ///         it happens depends on the application. Can only be called by the
     ///         given staking provider’s authorizer. Overwrites pending
     ///         authorization decrease for the given staking provider and
-    ///         application.
+    ///         application if the application agrees for that. If the
+    ///         application does not agree for overwriting, the function
+    ///         reverts.
     /// @dev Calls `authorizationDecreaseRequested` callback on the given
     ///      application. See `IApplication`.
     function requestAuthorizationDecrease(