ToJ set updates + artist credit fixes#34
ToJ set updates + artist credit fixes#34kayorga wants to merge 22 commits intothroneteki-playtesting:developmentfrom
Conversation
There was a problem hiding this comment.
i'm ready from my end to go live with this, i rolled the code-changes to support this set out to TDB just now.
the set needs a publication date and the workInProgress flag toggled to false, otherwise these card will show up as "work in progress" on the site.
some of the cards, like the one below, are still using the placeholder/auto-generated images.
also, that draftmancer/ToJ.txt file - is this needed in this repo? if not then please delete.
the ThronesDB cards importer is expecting these codes to be provided.
this will catch any typos in rarity values when running the `npm run validate`.
Draft fixes
Patane97
left a comment
Patane97
left a comment
There was a problem hiding this comment.
The changes seem good from my perspective with TheIronThrone.
@kayorga Just mentioning where this should be merged into; as the intent is for us to bring this to the live site (ie. workInProgress: false), I would recommend this actually merge into throneteki:master, rather than playtesting.
The changes from there will then (eventually) flow into development; I will handle the merge conflicts (that is an issue I have accepted with the playtesting -> live workflow for a while now, this would be no exception).
3 participants
No description provided.