Fix stream processor exiting early on empty CBOR data records#39
Open
dallonby wants to merge 3 commits intothrowaway31265:mainfrom
Open
Fix stream processor exiting early on empty CBOR data records#39dallonby wants to merge 3 commits intothrowaway31265:mainfrom
dallonby wants to merge 3 commits intothrowaway31265:mainfrom
Conversation
The same fix from PR throwaway31265#38 (19ac510) needs to be applied to stream.py. Some RAW files contain records where 'data' is an empty byte string. Calling cbor2.loads(b'') raises CBORDecodeEOF (inherits from EOFError), which was caught by the EOFError handler and broke out of the read loop. This caused the stream processor to only capture ~4 piezo records per sleep session instead of continuous data, resulting in only 2-3 vitals records per night instead of hundreds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@dallonby is attempting to deploy a commit to the david's projects Team on Vercel. A member of the Team first needs to authorize it. |
Implements automatic temperature adjustments based on biometric signals: - Shivering detection (warms up when user is cold) - Restlessness detection (cools down when user is too warm) - Sleep onset detection (cools down to help falling asleep) Includes safety limits, cooldown periods, and event logging for visualization. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit d554551.
|
Same fix as #38 — we patched this in sleepypod-core as well. Our shared Thanks for the detailed writeup — the vitals-per-night numbers really show the impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream.pydatafields before attempting CBOR decodeCBORDecodeEOFexception from breaking the read loopProblem
Some RAW files contain records where
datais an empty byte string (b''). Callingcbor2.loads(b'')raisesCBORDecodeEOFwhich inherits fromEOFError. The existingexcept EOFError: breakhandler caught this exception and exited the loop entirely.This caused the stream processor to only capture ~4 piezo records per sleep session instead of continuous data, resulting in only 2-3 vitals records per night instead of hundreds.
Test plan
free-sleep-streamservice🤖 Generated with Claude Code