fix: updated for node v24 use of npm ci#1128
Open
Silver-Golden wants to merge 1 commit intothsmi:masterfrom
Open
fix: updated for node v24 use of npm ci#1128Silver-Golden wants to merge 1 commit intothsmi:masterfrom
npm ci#1128Silver-Golden wants to merge 1 commit intothsmi:masterfrom
Conversation
Was failing in Nix builds, in those builds ``npm ci`` is called and there was a mismatch between ``package.json`` and ``package-lock.json`` which caused this command to fail. Packaged for Nix here: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/si/sieve-editor-gui/package.nix Failed log: https://hydra.nixos.org/build/316840533/nixlog/5
Author
|
@thsmi not sure how active ye are (last action was back in Jan/March) so I will also be having a patch downstream from ye (forcing node22) |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using node
v24.12.0I rannpm installto get the updated lockfile.NixOS recently updated the default nodejs to 24 (from 22)
NixOS/nixpkgs#462407
Was failing in Nix builds, in those builds
npm ciis called and there was a mismatch betweenpackage.jsonandpackage-lock.jsonwhich caused this command to fail.Packaged for Nix here: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/si/sieve-editor-gui/package.nix
Failed log: https://hydra.nixos.org/build/316840533/nixlog/5