Skip to content

Remove scrape missing previews option#1721

Merged
hjiangsu merged 1 commit intodevelopfrom
feat/remove-scrap-missing-previews
Mar 3, 2025
Merged

Remove scrape missing previews option#1721
hjiangsu merged 1 commit intodevelopfrom
feat/remove-scrap-missing-previews

Conversation

@hjiangsu
Copy link
Copy Markdown
Member

@hjiangsu hjiangsu commented Mar 3, 2025

Pull Request Description

This PR removes the remaining logic for scrape missing previews option mentioned in #1720. I've also added a migration step to remove existing instances of setting_general_scrape_missing_previews in SharedPreferences.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Copy Markdown
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Is there also a package we were using for this feature that could possibly be removed now?

@hjiangsu
Copy link
Copy Markdown
Member Author

hjiangsu commented Mar 3, 2025

Is there also a package we were using for this feature that could possibly be removed now?

There's the link_preview_generator package which was originally used for scraping but was later replaced by our own getLinkInfo function. From what I can tell, link_preview_generator is still used in two places:

  • The bottom sheet when long-pressing on a link
  • The create post page when generating a suggested title for a URL

While this is out of scope for this PR, we could fully remove link_preview_generator by updating these use-cases to use getLinkInfo instead!

@hjiangsu hjiangsu merged commit f3f6611 into develop Mar 3, 2025
1 check passed
@hjiangsu hjiangsu deleted the feat/remove-scrap-missing-previews branch March 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants