Conversation
Member
Author
|
I'll be merging this in first - do let me know if there's any issues with this @micahmo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR refactors parts of the compact post view card to improve readability and potentially performance! Similar to the
MediaViewrefactor, there may be follow-up PRs for additional changes. For now, the main updates include:TypeBadgetoMediaTypeBadgeand applied some optimizations.ThumbnailPreviewinto its own file (previously inpost_card_view_compact.dart) and renamed it toCompactThumbnailPreview. LikeMediaView, this widget no longer depends onPostViewMedia.PostStatusIconwidget (and additionally, a new enumPostStatus) to handle post statuses (e.g., locked, hidden, deleted, removed) next to the post title. This can later be used in the card post view widget to reduce code duplication.PostCardTitlewidget which generates the entire post title (alongside the statuses usingPostStatusIcon) - this can eventually be shared with all the different post card types (e.g., card, compact)Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?