Implement Operation and EnvelopeBodyContents for &T#80
Merged
babolivier merged 3 commits intomainfrom Feb 13, 2026
Merged
Conversation
jtracey
approved these changes
Feb 13, 2026
Contributor
jtracey
left a comment
jtracey
left a comment
There was a problem hiding this comment.
I'm a little nervous about using identical names to the owned types, but they really should be identical operations with these definitions, so it should be fine.
Member
Author
Yep it should be fine, and they need to translate to the same XML element names or the EWS requests wouldn't work, so there isn't really an alternative here. |
moz-v2v-gh
pushed a commit
to mozilla/releases-comm-central
that referenced
this pull request
Feb 19, 2026
This patch also pulls changes from the following PRs: * thunderbird/ews-rs#79 * thunderbird/ews-rs#80 * thunderbird/xml-struct-rs#11 Differential Revision: https://phabricator.services.mozilla.com/D283349 --HG-- extra : amend_source : 3ef8d00af3b4f770fed52c9b43438b33c2426c9e
github-actions bot
pushed a commit
to thunderbird/comm-unified-l10n
that referenced
this pull request
Feb 19, 2026
This patch also pulls changes from the following PRs: * thunderbird/ews-rs#79 * thunderbird/ews-rs#80 * thunderbird/xml-struct-rs#11 Differential Revision: https://phabricator.services.mozilla.com/D283349
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the changes I'm working on for bug 2010330, I'd like to make it possible for an
Envelope's body to be a reference on the operation struct instance rather than the instance itself. The reason is that I'm wrapping the instance into a struct that can be interacted with from the queue, and I'd like to be able to build the envelope without having to move the inner operation out of that struct.Requires thunderbird/xml-struct-rs#11